Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v5.2.0 #5664

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Release v5.2.0 #5664

merged 1 commit into from
Jun 10, 2024

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Apr 30, 2024 •
edited
Loading

@realbigsean
Copy link
Member

another to include: #5672

@realbigsean
Copy link
Member

and this #5675

@dapplion
Copy link
Collaborator

dapplion commented May 1, 2024

Note PR

Requires the following PR

or a fix to fail active requests in the sync network context upon peer disconnection

@jimmygchen
Copy link
Member

All above PRs mentioned has been included in this branch.

@michaelsproul michaelsproul force-pushed the cut-v5.2.0 branch 2 times, most recently from 74d1c37 to a94b649 Compare May 3, 2024 01:54
@michaelsproul
Copy link
Member Author

FYI for anyone following this PR: we are going to delay this release for a few weeks until after the first Electra devnet. Some bugs were found during testing that need to be fixed, and in parallel we need to keep working on Electra.

@michaelsproul
Copy link
Member Author

michaelsproul commented May 7, 2024 •
edited
Loading

Rebased on unstable and merged in the 3 outstanding PRs that we hope will fix the de-sync issues:

Removed:

@michaelsproul
Copy link
Member Author

Updated to include this PR which prevents unbounded disk usage!

@michaelsproul
Copy link
Member Author

Updated to include:

@michaelsproul michaelsproul force-pushed the cut-v5.2.0 branch 2 times, most recently from a6abac2 to 64edaf5 Compare May 30, 2024 04:54
@lrusak lrusak mentioned this pull request Jun 1, 2024
Merged
@michaelsproul michaelsproul force-pushed the cut-v5.2.0 branch 2 times, most recently from 6025349 to 5c2cf51 Compare June 6, 2024 05:00
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed do-not-merge labels Jun 10, 2024
@michaelsproul
Copy link
Member Author

Testing shows this is finally ready to go. I propose we merge it and release tomorrow (Tuesday Aus time)

jimmygchen
jimmygchen approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🎉

@michaelsproul
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Jun 10, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f1d88ba

@mergify mergify bot merged commit f1d88ba into unstable Jun 10, 2024
28 checks passed
@mergify mergify bot deleted the cut-v5.2.0 branch June 10, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review v5.2.0 Q2 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelsproul @realbigsean @dapplion @jimmygchen