Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate http-spec-fork and http-allow-sync-stalled #5430

Closed
michaelsproul opened this issue Mar 18, 2024 · 2 comments
Closed

Deprecate http-spec-fork and http-allow-sync-stalled #5430

michaelsproul opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels
backwards-incompat Backwards-incompatible API change HTTP-API UX-and-logs v5.2.0 Q2 2024

Comments

@michaelsproul
Copy link
Member

Description

We should make http-spec-fork and http-allow-sync-stalled into hidden no-op flags.

The semantics should be:

  • Keep the default spec fork, i.e. ignore http-spec-fork.
  • Remove the boolean for allow_sync_stalled and hardcode the logic as if it is true (i.e. make --http-allow-sync-stalled the new hardcoded default).

The first change is uncontroversial, we are just removing an option that was rarely used.

The second change is more substantial but I believe is in the right direction. We want to prioritise liveness for the HTTP API, and having the BN refuse to serve certain routes risks stalling the chain on small networks. On devnets and testnets the EF routinely add the --http-allow-sync-stalled flag, as its behaviour is slightly more reliable than the current default behaviour. Sync rarely enters into the Stalled state unless the node has very very few peers, and it's hard for us to tell apart "stalled because my node disconnected from the internet" and "stalled because the network is near death and needs me to continue it", so we may as well choose the safe option (allow) at the risk of producing some crappy blocks & attestations in rare cases.

@michaelsproul michaelsproul added HTTP-API UX-and-logs backwards-incompat Backwards-incompatible API change v5.2.0 Q2 2024 labels Mar 18, 2024
@michaelsproul
Copy link
Member Author

cc @eserilev

@jimmygchen
Copy link
Member

Completed in #5500 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change HTTP-API UX-and-logs v5.2.0 Q2 2024
Projects
None yet
Development

No branches or pull requests

3 participants