Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate http-spec-fork and http-allow-sync-stalled #5500

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Deprecate http-spec-fork and http-allow-sync-stalled #5500

merged 9 commits into from
Apr 12, 2024

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

#5430

Proposed Changes

Deprecate http-spec-fork
The default spec fork is now always chosen

Deprecate http-allow-sync-stalled
Remove allow_sync_stalled flag. Sync is now allowed by default

The issue description has justifications for these changes

chong-he
chong-he reviewed Mar 28, 2024
View reviewed changes
scripts/local_testnet/beacon_node.sh
@@ -67,5 +67,4 @@ exec $lighthouse_binary \
--target-peers $((BN_COUNT - 1)) \
--execution-endpoint $execution_endpoint \
--execution-jwt $execution_jwt \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the backlash in the previous line?

Suggested change
--execution-jwt $execution_jwt \
--execution-jwt $execution_jwt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, removed in a3e4f5e

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we need to keep it because $BN_ARGS is on the next line

@eserilev eserilev added the ready-for-review The code is ready for review label Apr 1, 2024
michaelsproul
michaelsproul reviewed Apr 1, 2024
View reviewed changes
book/src/help_bn.md Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 4, 2024
michaelsproul
michaelsproul approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will merge with these few tiny fixes applied

scripts/local_testnet/beacon_node.sh Outdated Show resolved Hide resolved
beacon_node/src/cli.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 11, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Apr 11, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Apr 12, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Apr 12, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6bac5ce

mergify bot added a commit that referenced this pull request Apr 12, 2024
@mergify
Merge of #5500
bc9c827
@mergify mergify bot mentioned this pull request Apr 12, 2024
Closed
5 tasks
@mergify mergify bot merged commit 6bac5ce into sigp:unstable Apr 12, 2024
30 checks passed
@jimmygchen jimmygchen mentioned this pull request May 1, 2024
Closed
@michaelsproul michaelsproul mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@chong-he chong-he chong-he left review comments

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eserilev @michaelsproul @chong-he