Builder updates for Blobs (EIP-4844) #3808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
changed the title
# Conflicts: # beacon_node/http_api/src/lib.rs
jimmygchen
force-pushed
the
builder-bid-4844
branch
from
dbde110
to
9f64803
Compare
jimmygchen
commented
Jan 11, 2023
| @@ -135,10 +134,10 @@ impl BuilderHttpClient { | |||
| } | |||
|
|
|||
| /// `POST /eth/v1/builder/blinded_blocks` | |||
| pub async fn post_builder_blinded_blocks<E: EthSpec>( | |||
| pub async fn post_builder_blinded_blocks<E: EthSpec, Payload: DeserializeOwned>( | |||
There was a problem hiding this comment.
I was thinking to create a trait for ExecutionPayload and ExecutionPayloadAndSidecar to restrict the bound, but having some issues with getting this to compile
pub trait BuilderExecutionPayloadResponse: DeserializeOwned {}
impl<T: EthSpec> BuilderExecutionPayloadResponse for ExecutionPayloadAndBlobsSidecar<T> {}
impl<T: EthSpec> BuilderExecutionPayloadResponse for ExecutionPayload<T> {}
|
@realbigsean I have implemented the most of the changes we discussed earlier. I'm now trying to work on the tests, but would be helpful if you could review the changes I have so far when you have some time. |
# Conflicts: # beacon_node/execution_layer/src/lib.rs # beacon_node/http_api/src/publish_blocks.rs # lcli/src/new_testnet.rs
# Conflicts: # beacon_node/execution_layer/src/lib.rs # beacon_node/execution_layer/src/test_utils/mock_builder.rs # beacon_node/http_api/src/publish_blocks.rs # common/eth2_network_config/src/lib.rs # consensus/types/src/execution_payload.rs
divagant-martian
force-pushed
the
eip4844
branch
from
86e6906
to
55753f8
Compare
|
This one is getting quite outdated, new draft PR created here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#3689
Builder spec: ethereum/builder-specs#61
4844 Builder flow: https://hackmd.io/@jimmygchen/B1dLR74Io
Proposed Changes
Builder updates for blobs. Implemented based on builder spec PR here.
BuilderBidvariants forEip4844get_payloadresponse containingkzg_blob_commitments(Eip4844variant ofBuilderBid)propose_blinded_beacon_blockresponse containing blobs sidecarBuilderBiddeserialization issues. See tests.clone()&unwrapwere added to make things compile.