Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Validator Client fallback mechanism #4393

Merged
merged 69 commits into from
Oct 3, 2024
Merged

Rework Validator Client fallback mechanism #4393

merged 69 commits into from
Oct 3, 2024

Conversation

macladson
Copy link
Member

@macladson macladson commented Jun 13, 2023 •
edited
Loading

Issue Addressed

#3613

Proposed Changes

  • Reworks large sections of the validator fallback mechanism.
  • Uses health tiers to sort beacon nodes by healthiest first.
  • Considers beacon node sync distance, optimistic status and execution status.

Each connected BN is queried every slot by the VC and is then sorted in a priority list. When attempting to perform duties, the VC will use the healthiest BN first (within a configurable tolerance).

Additional Info

  • There is currently no lockout period. This means if a BN fails a request, it will still be tried next epoch if it is seemingly healthy.
  • Removes the RequireSynced enum. This was scarcely used but may have implications when removed.
  • Removes the OfflineOnFailure enum. This was also scarcely used. In the new system, beacon nodes are never marked as offline so in essence have OfflineOnFailure::No by default.

Remaining Work

  • CLI configurable distance tier modifiers.
  • Actually use the status field on CandidateBeaconNode or remove it entirely.
  • Fix logging since a lot of it was removed and not replaced.
  • Make a /lighthouse/ui endpoint which exposes the fallback health stats for siren.
  • Create working simulator to test fallback mechanism.

@macladson macladson added work-in-progress PR is a work-in-progress val-client Relates to the validator client binary labels Jun 13, 2023
@macladson macladson force-pushed the vc-fallback branch 2 times, most recently from 2226ed9 to 7e96756 Compare June 16, 2023 04:30
@macladson macladson marked this pull request as ready for review August 1, 2023 04:37
@macladson macladson added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Aug 3, 2023
@paulhauner paulhauner self-assigned this Aug 4, 2023
@macladson macladson added the ready-for-review The code is ready for review label Sep 11, 2024
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 30, 2024
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 2, 2024
AgeManning
AgeManning approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming to approve Jimmy's last commit on this.

I've not reviewed this PR

jimmygchen
jimmygchen approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice one, finally 😭 🎉
Will raise a separate issue to revisit the locks. I think #6413 (lockbud) will also help.

@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Oct 3, 2024 •
edited
Loading

queue

🛑 Branch protection settings are not validated anymore

Branch protection is enabled and is preventing Mergify to merge the pull request. Mergify will merge when branch protection settings validate the pull request once again. (detail: 1 review requesting changes and 2 approving reviews by reviewers with write access.)

@jimmygchen jimmygchen mentioned this pull request Oct 3, 2024
Open
@jimmygchen
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Oct 3, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Oct 3, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f870b66

@mergify mergify bot merged commit f870b66 into sigp:unstable Oct 3, 2024
29 checks passed
This was referenced Oct 26, 2024
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@dapplion dapplion dapplion left review comments

@AgeManning AgeManning AgeManning approved these changes

@michaelsproul michaelsproul Awaiting requested review from michaelsproul

@paulhauner paulhauner Awaiting requested review from paulhauner

Assignees

@paulhauner paulhauner

Labels
ready-for-review The code is ready for review v6.0.0 New major release for hierarchical state diffs val-client Relates to the validator client binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@macladson @paulhauner @chong-he @jimmygchen @AgeManning @dapplion @michaelsproul