Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update Lighthouse book FAQ #4510

Closed
wants to merge 8 commits into from

Conversation

chong-he
Copy link
Member

Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct.

Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've got a few nit-picks and some wording/grammar suggestions for you, but otherwise these are good updates 👍

book/src/faq.md Outdated Show resolved Hide resolved
book/src/faq.md Show resolved Hide resolved
book/src/faq.md Outdated Show resolved Hide resolved
book/src/faq.md Outdated Show resolved Hide resolved
book/src/faq.md Outdated Show resolved Hide resolved
book/src/faq.md Outdated Show resolved Hide resolved
book/src/faq.md Outdated Show resolved Hide resolved
Co-authored-by: Mac L <mjladson@pm.me>
@chong-he
Copy link
Member Author

Nice! I've got a few nit-picks and some wording/grammar suggestions for you, but otherwise these are good updates 👍

Thanks so much for the review. Committed all changes and waiting the confirmation on the two similar Q&A.

@paulhauner paulhauner added the ready-for-merge This PR is ready to merge. label Jul 31, 2023
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 31, 2023
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. 

Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 31, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 31, 2023
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. 

Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
@paulhauner
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Jul 31, 2023

Canceled.

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 31, 2023
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. 

Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
@bors
Copy link

bors bot commented Aug 1, 2023

@bors bors bot changed the title Update Lighthouse book FAQ [Merged by Bors] - Update Lighthouse book FAQ Aug 1, 2023
@bors bors bot closed this Aug 1, 2023
@chong-he chong-he deleted the book-faq branch December 3, 2023 09:46
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. 

Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. 

Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants