-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update Lighthouse book FAQ #4510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've got a few nit-picks and some wording/grammar suggestions for you, but otherwise these are good updates 👍
Co-authored-by: Mac L <mjladson@pm.me>
Thanks so much for the review. Committed all changes and waiting the confirmation on the two similar Q&A. |
bors r+ |
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Build failed (retrying...): |
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
bors r- |
Canceled. |
bors r+ |
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct. Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Some updates in the FAQ based on issues seen on Discord. Additionally, corrected the disk usage on the default SPRP as the previously provided value is not correct.