Use histograms for BeaconProcessor queue lengths
#4515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dapplion
added
waiting-on-author
|
Superseded by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Uses a Prometheus historgram to track the lengths of queues in the beacon processor.
We're currently using a gauge, which ends up reporting the queue length at exactly the time of metrics scraping. This is not so useful since it doesn't capture peaks/troughs between scrapes. A histogram will give us more of an average over time (but in a discrete, bucket-y sorta way).
Additional Info
I've removed the
BEACON_PROCESSOR_<OBJECT>_QUEUE_TOTALandBEACON_PROCESSOR_REPROCESSING_QUEUE_TOTALmetrics. I was in two minds about removing/renaming the old metrics or just changing their underlying data type. I settled on removing/renaming since it should play nicer with setups that have a mix of old/new versions of Lighthouse.Blocked on #4462.