Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Polish] - Prefer test_logger over null_logger #4545

Closed
wants to merge 1 commit into from
Closed

[Polish] - Prefer test_logger over null_logger #4545

wants to merge 1 commit into from

Conversation

tibi77
Copy link

@tibi77 tibi77 commented Jul 27, 2023

Issue Addressed

#4499

Proposed Changes

Change null_logger in test_logger

Additional Info

anvil test panics locally, pushed this to see if it does on the github action as well

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tibi77 tibi77 changed the base branch from stable to unstable July 27, 2023 03:02
@tibi77 tibi77 changed the title Tibi77/null logger test logger [Polish] - Prefer test_logger over null_logger Jul 27, 2023
@tibi77
Copy link
Author

tibi77 commented Jul 30, 2023

hey @jmcph4 i m unsure what i need to do to ask for review in this project. Tagging you in here as you have created the request.

@jmcph4
Copy link
Member

jmcph4 commented Aug 28, 2023

hey @jmcph4 i m unsure what i need to do to ask for review in this project. Tagging you in here as you have created the request.

make lint should satisfy the lint CI job and also re-run CI which will refresh the target branch check.

@dapplion dapplion added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Jan 19, 2024
@dapplion
Copy link
Collaborator

Duplicate of

@tibi77 tibi77 closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tibi77 @CLAassistant @jmcph4 @dapplion