Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix typo #4555

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix typo #4555

wants to merge 1 commit into from

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Aug 1, 2023 •
edited by bors bot
Loading

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paulhauner paulhauner changed the base branch from stable to unstable August 2, 2023 07:38
paulhauner
paulhauner approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@paulhauner paulhauner added the ready-for-merge This PR is ready to merge. label Aug 2, 2023
@paulhauner
Copy link
Member

Could you please push an empty commit so Github can see that I've changed the target branch 🙏

@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Aug 2, 2023
@paulhauner paulhauner self-assigned this Aug 2, 2023
@zhiqiangxu
Copy link
Contributor Author

Could you please push an empty commit so Github can see that I've changed the target branch 🙏

Done.

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 2, 2023
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 2, 2023
@zhiqiangxu
fix typo (#4555)
646837a
@bors
Copy link

bors bot commented Aug 2, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 2, 2023
@zhiqiangxu
fix typo (#4555)
fcf51d6
@bors
Copy link

bors bot commented Aug 3, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix typo [Merged by Bors] - fix typo Aug 3, 2023
@bors bors bot closed this Aug 3, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@zhiqiangxu @Woodpile37
fix typo (sigp#4555)
ff30a3f
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@zhiqiangxu @Woodpile37
fix typo (sigp#4555)
3b8baee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees

@paulhauner paulhauner

Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangxu @CLAassistant @paulhauner