-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and make block hash calculation public #5275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
The code is ready for review
low-hanging-fruit
Easy to resolve, get it before someone else does!
v5.1.0
Q2 2024
labels
Feb 22, 2024
michaelsproul
force-pushed
the
verify-typo
branch
from
February 22, 2024 01:38
e514bf4
to
5911e03
Compare
michaelsproul
changed the title
Fix typo in
Fix typos and make block hash calculation public
Feb 22, 2024
verify_payload_block_hash
dapplion
approved these changes
Feb 22, 2024
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Feb 25, 2024
@Mergifyio dequeue |
☑️ The pull request is not queued |
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 744c598 |
This was referenced Feb 26, 2024
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
low-hanging-fruit
Easy to resolve, get it before someone else does!
ready-for-merge
This PR is ready to merge.
v5.1.0
Q2 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
verfiy => verify
calculate_execution_block_hash
public again so it can be used downstream by projects likeeleel
.