Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking unstable (f4cdcea) and #5279 together #5522

Closed
wants to merge 27 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 4, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch unstable (f4cdcea) and #5279 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #5279.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue default for merge:

  • check-success=local-testnet-success
  • check-success=test-suite-success

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 5279
...

dapplion and others added 27 commits February 8, 2024 16:33
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
* Delete unused epoch processing code

* Compare total deltas

* Remove unnecessary apply_pending

* cargo fmt

* Remove newline
* spec compliant process_sync_aggregate

* Update consensus/state_processing/src/per_block_processing/altair/sync_committee.rs

Co-authored-by: Michael Sproul <micsproul@gmail.com>

---------

Co-authored-by: Michael Sproul <micsproul@gmail.com>
* Address most of Sean's review comments

* Simplify total balance cache building
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ dapplion
✅ michaelsproul
❌ mergify[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@mergify mergify bot closed this Apr 4, 2024
@mergify mergify bot deleted the mergify/merge-queue/bd69420ca5 branch April 4, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants