Revert Arced pubkey optimization #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
force-pushed
the
tree-states-memory-revert-pubkey
branch
from
84e54bf
to
8b6ecdd
Compare
michaelsproul
merged commit 8fda723
into
sigp:tree-states-memory
16 of 28 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Consensus changes * EF tests * lcli * common and watch * account manager * cargo * fork choice * promise cache * beacon chain * interop genesis * http api * lighthouse * op pool * beacon chain misc * parallel state cache * store * fix issues in store * IT COMPILES * Remove some unnecessary module qualification * Revert Arced pubkey optimization (#5536) * Merge remote-tracking branch 'origin/unstable' into tree-states-memory * Fix caching, rebasing and some tests * Remove unused deps * Merge remote-tracking branch 'origin/unstable' into tree-states-memory * Small cleanups * Revert shuffling cache/promise cache changes * Fix state advance bugs * Fix shuffling tests * Remove some resolved FIXMEs * Remove StateProcessingStrategy * Optimise withdrawals calculation * Don't reorg if state cache is missed * Remove inconsistent state func * Fix beta compiler * Rebase early, rebase often * Fix state caching behaviour * Update to milhouse release * Fix on-disk consensus context format * Merge remote-tracking branch 'origin/unstable' into tree-states-memory * Squashed commit of the following: commit 3a16649 Author: Michael Sproul <michael@sigmaprime.io> Date: Thu Apr 18 14:26:09 2024 +1000 Fix on-disk consensus context format * Keep indexed attestations, thanks Sean * Merge branch 'on-disk-consensus-context' into tree-states-memory * Merge branch 'unstable' into tree-states-memory * Address half of Sean's review * More simplifications from Sean's review * Cache state after get_advanced_hot_state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Features an optimization to de-duplicate the pubkey when an individual validator record is mutated. Since this optimization is not critical for tree states, let's drop it from the original PR to make the changes easier to digest.
Proposed Changes
Revert Arced pubkey optimization + compact beacon state