-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix execution layer redundancy #5588
Fix execution layer redundancy #5588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! It's a nice cleanup, just had one small suggestion
Looks like some tests need updating as well, if you want to check locally whether tests compile |
@realbigsean thanks for review. Actually I ran |
ah there must be some tests are are missed. usually i also run |
@realbigsean fixed the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
🛑 The pull request has been removed from the queue
|
@Mergifyio requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 62e4abf |
Issue Addressed
#3307
Proposed Changes
renamed and changed types(from Vec to Option) of below fields of Config struct:
execution_endpoints: Vec => execution_endpoint: Option
secret_files: Vec => secret_file: Option
Additional Info