Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only portable builds (docker) #5614

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

antondlr
Copy link
Member

See #5489 for details, this is a cleaner version of the docker part of that PR

For backwards compatibility, we still publish all the different "specialised" (i.e., -dev) docker image tags (pointing to one image). This is meant to be phased out as we direct our users towards the regular image tag.

@antondlr
Copy link
Member Author

fyi the published docker image would no longer include slasher-mdbx with these proposed changes, I guess that means a breaking change (or re-adding it here) ?

@realbigsean
Copy link
Member

slasher-mdbx

is there a reason for dropping it? I have no idea if it's used, or if we want to keep experimenting with it

@realbigsean realbigsean added the backwards-incompat Backwards-incompatible API change label Apr 23, 2024
@antondlr
Copy link
Member Author

not really, my takeaway after reading this was that it was in silent deprecation but I'm probably totally wrong
let's consult the oracle to make sure @michaelsproul

@realbigsean
Copy link
Member

not really, my takeaway after reading this was that it was in silent deprecation but I'm probably totally wrong

Reading that makes me think it should be alright to stop publishing it with the standard image. Would you mind pulling in unstable to get CI passing?

If this is blocking people we can merge and follow up with a PR to re-add slasher-mdbx if our oracle guides us a different direction

@sebastianst
Copy link

Are you gonna publish new multi-arch docker images right after this is merged? (context)

@antondlr
Copy link
Member Author

Are you gonna publish new multi-arch docker images right after this is merged? (context)

a latest-unstable multiarch image will be automatically published after successful merge!

@realbigsean
Copy link
Member

@mergify queue

Copy link

mergify bot commented Apr 23, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 76460ba

mergify bot added a commit that referenced this pull request Apr 23, 2024
@mergify mergify bot merged commit 76460ba into sigp:unstable Apr 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change infra-ci ready-for-review The code is ready for review v5.2.0 Q2 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants