Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml rust2 #5635

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Yaml rust2 #5635

merged 1 commit into from
Apr 24, 2024

Conversation

realbigsean
Copy link
Member

Issue Addressed

Our docker cross builds have been failing since this PR got merged: #5612

I think serde_yml brought in some deps causing issue. I noticed serde_yml was archived a few weeks ago. Figured we could switch to the community maintained fork of rust-yaml (which is what we were using initially) called rust-yaml2

@realbigsean realbigsean added ready-for-review The code is ready for review bug Something isn't working low-hanging-fruit Easy to resolve, get it before someone else does! labels Apr 23, 2024
@realbigsean realbigsean requested a review from jxs April 23, 2024 22:01
@jimmygchen
Copy link
Member

I realized serde_yml is not the same as serde_yaml (deprecated).
serde_yml is less than a month old though, so switching to the community maintained rust-yaml2 makes sense.

jimmygchen
jimmygchen approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 24, 2024
@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Apr 24, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c4a2bcb

mergify bot added a commit that referenced this pull request Apr 24, 2024
@mergify
Merge of #5635
9542ed1
This was referenced Apr 24, 2024
Closed
Merged
Merged
Merged
@mergify mergify bot merged commit c4a2bcb into sigp:unstable Apr 24, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@jxs jxs Awaiting requested review from jxs

Assignees
No one assigned
Labels
bug Something isn't working low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realbigsean @jimmygchen