Migrate validator client to clap derive #6300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
changed the title
eserilev
commented
Aug 23, 2024
Comment on lines
+270
to
+275
| if validator_client_config.web3_signer_keep_alive_timeout == 0 { | ||
| config.web3_signer_keep_alive_timeout = None | ||
| } else { | ||
| config.web3_signer_keep_alive_timeout = Some(Duration::from_millis( | ||
| validator_client_config.web3_signer_keep_alive_timeout, | ||
| )); |
There was a problem hiding this comment.
Note the breaking change here. Since I've defined web3_signer_keep_alive_timeout as a u64, null is no longer a valid option. Users will need to use 0 instead.
If this breaking change is too intrusive I can define web3_signer_keep_alive_timeout as a string and we can keep functionality as is.
eserilev
added
work-in-progress
eserilev
added
ready-for-review
eserilev
added
ready-for-review
macladson
reviewed
Oct 18, 2024
macladson
added
waiting-on-author
…ap-derive-validator-manager
eserilev
added
ready-for-review
macladson
reviewed
Oct 25, 2024
| @@ -430,7 +437,7 @@ fn no_doppelganger_protection_flag() { | |||
| fn no_gas_limit_flag() { | |||
| CommandLineTest::new() | |||
| .run() | |||
| .with_config(|config| assert!(config.gas_limit.is_none())); | |||
| .with_config(|config| assert!(config.gas_limit == Some(30_000_000))); | |||
There was a problem hiding this comment.
Is there a functional difference between None and 30_000_000 here? Might be worth now renaming this test to gas_limit_flag_default to better match the naming scheme.
validator_client/src/config.rs
Outdated
| validator_client_config.enable_doppelganger_protection; | ||
| config.builder_proposals = validator_client_config.builder_proposals; | ||
| config.prefer_builder_proposals = validator_client_config.prefer_builder_proposals; | ||
| config.gas_limit = Some(validator_client_config.gas_limit); |
There was a problem hiding this comment.
If gas limit now defaults to Some, can we remove the Option altogether?
macladson
reviewed
Oct 27, 2024
macladson
added
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #5900
Proposed Changes
Migrate the validator client cli to clap derive