Include compiler version in lighthouse --version
#6392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
|
Related: |
dapplion
reviewed
Sep 14, 2024
| @@ -85,6 +87,29 @@ fn build_profile_name() -> String { | |||
| .to_string() | |||
| } | |||
|
|
|||
| fn compiler_version() -> String { | |||
| let version = rustc_version::version_meta().expect("should be able to fetch compiler version"); | |||
There was a problem hiding this comment.
This will error if the command rustc -vV fails to run.
https://docs.rs/rustc_version/0.4.1/src/rustc_version/lib.rs.html#201
https://docs.rs/rustc_version/0.4.1/src/rustc_version/lib.rs.html#180
Is this run on compilation of on every run of LH?
There was a problem hiding this comment.
oh shit I think you're right, this is running at runtime 🤦♂️
michaelsproul
added
waiting-on-author
|
I don't know how to fix this easily, and it's low prio so I'm not going to spend any time on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In aid of making builds easier to reproduce, include the compiler's version information in
lighthouse --version.Initial testing for reproducible builds shows that Lighthouse can't (yet) be built bit-identically by
make build-x86_64for the same commit hash & compiler version :(See: