Separate type for unaggregated network attestations #6427
+1,517
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
electra
…ngle_attestation_electra
eserilev
added
ready-for-review
eserilev
commented
Oct 7, 2024
consensus/types/src/attestation.rs
Outdated
| @@ -350,6 +360,57 @@ impl<E: EthSpec> AttestationElectra<E> { | |||
| Ok(()) | |||
| } | |||
| } | |||
|
|
|||
| pub fn to_single_attestation(&self) -> Result<SingleAttestation, Error> { | |||
There was a problem hiding this comment.
can convert single attestation into indexed attestation w/o computing the committee index
eserilev
added
work-in-progress
…ngle_attestation_electra
|
|
…ngle_attestation_electra
eserilev
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #6380
Proposed Changes
Spec: ethereum/consensus-specs#3900
The invasive spec changes are being worked on here. This is going to include some larger refactors