Update to latest discovery #6486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
approved these changes
Oct 16, 2024
jxs
approved these changes
Oct 17, 2024
|
Yeah. I've been testing with ipv6 using discv5-cli. There are probably some other changes we might need to introduce for ipv6 however. I've not quite got to them yet. |
|
I've made a new commit. Moves to a whole new discovery. I think this current version should be fine to support ipv6 and potentially dual-stack by default |
pawanjay176
reviewed
Oct 30, 2024
| .query_peer_timeout(Duration::from_secs(2)) | ||
| .query_timeout(Duration::from_secs(30)) | ||
| .request_retries(1) | ||
| .enr_peer_update_min(10) | ||
| .query_parallelism(5) | ||
| .query_parallelism(8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update brings a few changes.
Specifically: