Fix incorrect mappigns in the Fluke 28x unit table #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to modify the various lookup tables at runtime. Declare these as const to avoid surprises. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
The Fluke 28x unit mapping has a couple of bugs: 'dBm' incorrectly maps to SQ_MQ_VOLTAGE and 'AAC_PLUS_DC' incorrectly maps to SR_MQ_VOLTAGE. Fix these issues. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
The VAC_PLUS_DC and AAC_PLUS_DC units measure the sum of the AC and DC components. Set both the SR_MQFLAG_AC and SR_MQFLAG_DC flags in these cases. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
biot
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fluke 28x unit mapping has a couple of bugs: 'dBm' incorrectly maps to SQ_MQ_VOLTAGE and 'AAC_PLUS_DC' incorrectly maps to SR_MQ_VOLTAGE. Fix these issues and set both the AC and DC flags for sum measurements.