Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more required CI to model_transparency. #478

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mihaimaruseac
Copy link
Contributor

Summary

Add a few more required CI checks for model-transparency repository to make sure we don't accidentaly merge PRs before these get a chance to run (due to slow down in provisioning or due to misconfiguration). We're adding several lint jobs and jobs to test the model signing library on Linux only. The repository has several other CI jobs, but those will not be marked as required.

These are added and tested in
sigstore/model-transparency#283.

Release Note

NONE

Documentation

NONE

These are added and tested in
sigstore/model-transparency#283.

We only require Linux checks for the model signing library and
linting/py-style.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac mihaimaruseac requested review from a team as code owners August 14, 2024 18:58
Copy link

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
  Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/cbace12c-8bd2-434b-afd0-bc734be02b0d

@ Previewing update.....
pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
  ~ github:index/branchProtection:BranchProtection: (update)
      [id=BPR_kwDOKKk2Ts4DA1PL]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::model-transparency-main]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_3::dfb01c0f-bb2a-45c2-9d92-e6152b5cee06]
    ~ requiredStatusChecks: [
        ~ [0]: {
                ~ contexts: [
                      [0]: "DCO"
                    + [1]: "Lint / Lint whitespace (pull_request)"
                    + [2]: "Lint / Python lint (pull_request)"
                    + [3]: "Lint / Type Check (pull_request)"
                    + [4]: "Run unit tests / Signing with Python 3.11 on Linux (pull_request)"
                    + [5]: "Run unit tests / Signing with Python 3.12 on Linux (pull_request)"
                  ]
              }
      ]
@ Previewing update....
Resources:
  ~ 1 to update
  591 unchanged
  

@haydentherapper haydentherapper merged commit 52def62 into sigstore:main Aug 14, 2024
2 checks passed
mihaimaruseac added a commit to mihaimaruseac/sigstore-community that referenced this pull request Aug 14, 2024
I was wrong in sigstore#478: the checks need to be as they show up in the job
name, not how they show up in the GHA summary at the bottom of the PR.

Since I used the wrong ones,
sigstore/model-transparency#284 is now waiting
on checks that cannot run. But I cna fix that by closing and reopening
once the required checks are in the correct format.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
haydentherapper pushed a commit that referenced this pull request Aug 14, 2024
I was wrong in #478: the checks need to be as they show up in the job
name, not how they show up in the GHA summary at the bottom of the PR.

Since I used the wrong ones,
sigstore/model-transparency#284 is now waiting
on checks that cannot run. But I cna fix that by closing and reopening
once the required checks are in the correct format.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants