Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set tls config while retaining other fields from default http transport #4007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nianyush
Copy link

@nianyush nianyush commented Jan 12, 2025

Signed-off-by: Nianyu Shen xiaoyu9964@gmail.com

Summary

original issue #3269
Proxy from environment variable is not respected while setting insecure true.
At

opts = append(opts, remote.WithTransport(&http.Transport{TLSClientConfig: tlsConfig}))
, its initializing an empty transport with only insecure set but those default behaviors from default transport is also gone. In this case, proxy value from envs is removed. The fix is to clone a default transport object and override the tlsconfig inside it.

Release Note

Documentation

…ansport

Signed-off-by: Nianyu Shen <xiaoyu9964@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant