Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default for isCA value in basic constraints extension #920

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

bdehamer
Copy link
Collaborator

Updates the X509BasicConstraintsExtension in the @sigstore/core package to ensure that that isCA property defaults to false in scenarios where there is no explicit value encoded in the extension (per the spec).

Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer requested a review from a team as a code owner December 29, 2023 22:52
Copy link

changeset-bot bot commented Dec 29, 2023

🦋 Changeset detected

Latest commit: 61a7bc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sigstore/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bdehamer bdehamer changed the title default for isCA value in basic const extension default for isCA value in basic constraints extension Dec 29, 2023
Copy link
Contributor

@ejahnGithub ejahnGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@bdehamer bdehamer merged commit 922a1be into main Jan 3, 2024
24 checks passed
@bdehamer bdehamer deleted the bdehamer/fix-cert-isca-default branch January 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants