Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose signature on SignatureContent #922

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

bdehamer
Copy link
Collaborator

Updates the SignatureContent type to expose a public signature property which gives direct access to the bytes of the signature. This is necessary for RFC3161 timestamp verification since the timestamp signature is generated over the bytes of the attestation signature.

Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer requested a review from a team as a code owner December 29, 2023 23:59
Copy link

changeset-bot bot commented Dec 29, 2023

🦋 Changeset detected

Latest commit: 9db4aea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sigstore/verify Patch
sigstore Patch
@sigstore/conformance Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bdehamer bdehamer requested a review from ejahnGithub January 3, 2024 21:25
Copy link
Contributor

@ejahnGithub ejahnGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdehamer bdehamer merged commit 45903bc into main Jan 4, 2024
24 checks passed
@bdehamer bdehamer deleted the bdehamer/signature-content-sig branch January 4, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants