Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the yaml worker for yaml syntax highlighting, #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clementwanjau
Copy link

Added a yaml worker to handle yaml syntax and color highlighting.

@ctron
Copy link
Collaborator

ctron commented Nov 7, 2023

I am wondering if it would make sense to have additional workers enabled by features?

@clementwanjau
Copy link
Author

That's a great idea. So you can only enable those that you need.

@dancixx
Copy link

dancixx commented Feb 1, 2024

@clementwanjau can you please add pgsql worker too? I tried to do the same but it didn't work for me. -,-

@clementwanjau
Copy link
Author

@clementwanjau can you please add pgsql worker too? I tried to do the same but it didn't work for me. -,-

@dancixx sure, I can try and do that

@dancixx
Copy link

dancixx commented Feb 2, 2024

@clementwanjau my process was to generate one file bundle using bun bundler and add it the same way as you did. I have bundled this package: monaco-sql-languages, but the worker was not loaded for some reason. If you can do this, please share the steps; I would likely do the same with the other SQL languages. Thanks for your effort.

@dancixx
Copy link

dancixx commented Feb 15, 2024

@clementwanjau could you do something with this?

@clementwanjau
Copy link
Author

@dancixx Did you succeed in implementing your pgsql worker?

@dancixx
Copy link

dancixx commented Jul 4, 2024

@clementwanjau No I couldn't do that, I tried it several times but it's still not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants