added video upload by title and description #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 69.9% 69.85% -0.05%
==========================================
Files 18 18
Lines 1409 1410 +1
==========================================
Hits 985 985
- Misses 251 252 +1
Partials 173 173
Continue to review full report at Codecov.
|
| @@ -226,7 +226,8 @@ func (v Video) GetID() int { | |||
| // UploadVideoRequest specifies the optional parameters to the | |||
| // uploadVideo method. | |||
| type UploadVideoRequest struct { | |||
| FileName string `json:"file_name"` | |||
There was a problem hiding this comment.
file_name required field for replace video
| @@ -558,15 +558,15 @@ func (s *UsersService) GetVideo(uid string, vid int, opt ...CallOption) (*Video, | |||
| // Passing the empty string will edit authenticated user. | |||
| // | |||
| // Vimeo API docs: https://developer.vimeo.com/api/playground/users/%7Buser_id%7D/videos | |||
| func (s *UsersService) UploadVideo(uid string, file *os.File) (*Video, *Response, error) { | |||
| func (s *UsersService) UploadVideo(uid, title, description string, file *os.File) (*Video, *Response, error) { | |||
There was a problem hiding this comment.
Maybe create UploadVideoWithTitle or the like for save backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.