Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21934: fork task to stop parser so control returns to user #209

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Nov 18, 2024

This is about https://jira.sil.org/browse/LT-21934.

Michael Lee asked that StopParser could return immediately so the user can get back to work while the parser still times out gracefully in the background. I added a condition that thread.Stop() wouldn't be called while the parser was updating wordforms since thread.Stop() turns into an abort after 60 seconds, and that can leave things in a funny state.

Jason wanted to review this code.


This change is Reviewable

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @jtmaxwell3)


Src/LexText/ParserCore/ParseFiler.cs line 88 at r2 (raw file):

		/// Are we updating word forms?
		/// </summary>
		public bool UpdatingWordforms;

No longer needed right?

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) November 20, 2024 15:40
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@JakeOliver28 JakeOliver28 merged commit 1a3797b into release/9.1 Nov 25, 2024
5 checks passed
@JakeOliver28 JakeOliver28 deleted the LT-21934c branch November 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants