Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and Document Localization #326

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Implement and Document Localization #326

merged 15 commits into from
Oct 18, 2023

Conversation

papeh
Copy link
Contributor

@papeh papeh commented Oct 5, 2023 •
edited by jasonleenaylor
Loading

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Test Results

    1 files   -     1  101 suites   - 101   14m 35s ⏱️ - 30m 12s
875 tests ±    0  832 ✔️  -   21  43 💤 +21  0 ❌ ±0 
998 runs   - 998  955 ✔️  - 976  43 💤  - 22  0 ❌ ±0 

Results for commit 6b86ff7. ± Comparison against base commit 84e6de0.

This pull request skips 21 tests. 
BasicCommitHasCommitFileButNotMergeFile
EncryptPassword_RoundTrips
GetIsReadyForInternetSendReceive_HasFullLangForgeUrlAndSavedCredentials_ReturnsTrue
InitFromUri_NoUsernameOrPass_UsesSettings
InitFromUri_UsernameAndPass_OverwritesSettings
PasswordForSession_UsesSaved("")
PasswordForSession_UsesSaved("myPass")
PasswordForSession_UsesSaved(null)
RememberPassword("temporary","",False)
RememberPassword(null,"",False)
…

♻️ This comment has been updated with latest results.

@papeh papeh changed the title Add documentation about lacking documentation Implement and Document Localization Oct 9, 2023
@papeh
Copy link
Contributor Author

papeh commented Oct 9, 2023 •
edited
Loading

-TODO- DONE: delete .tmx files; ignore .xlf files

@papeh papeh marked this pull request as ready for review October 10, 2023 16:56
@papeh papeh requested a review from ermshiperete October 13, 2023 14:33
@papeh papeh enabled auto-merge (squash) October 18, 2023 16:07
@papeh papeh requested a review from tombogle October 18, 2023 18:16
tombogle
tombogle approved these changes Oct 18, 2023
View reviewed changes
Copy link

@tombogle tombogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 8 files at r2, 15 of 15 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ermshiperete)

@papeh papeh merged commit dc230d5 into master Oct 18, 2023
4 checks passed
@papeh papeh deleted the fix/l10n-doc branch October 18, 2023 21:12
@rmunn rmunn mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombogle tombogle tombogle approved these changes

@ermshiperete ermshiperete Awaiting requested review from ermshiperete

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@papeh @tombogle