Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to net462 and update libpalaso #358

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Nov 26, 2024

This change is Reviewable

Copy link

github-actions bot commented Nov 26, 2024

Test Results

       8 files  ±0     333 suites  ±0   2h 23m 16s ⏱️ ±0s
   988 tests ±0     932 ✔️ ±0    56 💤 ±0  0 ±0 
3 145 runs  ±0  3 022 ✔️ ±0  123 💤 ±0  0 ±0 

Results for commit 055beb1. ± Comparison against base commit 56b1609.

♻️ This comment has been updated with latest results.

@jasonleenaylor jasonleenaylor force-pushed the chore/updatelibpalaso branch 3 times, most recently from fa745fd to f2f6b3b Compare November 26, 2024 15:19
@jasonleenaylor jasonleenaylor force-pushed the chore/updatelibpalaso branch 4 times, most recently from eb73090 to ae979c3 Compare November 26, 2024 21:38
@jasonleenaylor jasonleenaylor marked this pull request as ready for review November 26, 2024 21:38
@jasonleenaylor jasonleenaylor force-pushed the chore/updatelibpalaso branch 2 times, most recently from b9533ee to 2914d62 Compare November 26, 2024 23:02
* This brings in a new version of L10nSharp with API changes
Copy link
Contributor

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rmunn
Copy link
Contributor

rmunn commented Nov 27, 2024

I found a couple more places where net461 would need to be adjusted to net462 and pushed commit 055beb1 to deal with them. I haven't been able to test the change to l10n/l10n.proj, so please feel free to revert that change (or any of them) if it/they turn out to be wrong.

@jasonleenaylor jasonleenaylor merged commit 49493f8 into master Nov 27, 2024
8 of 12 checks passed
@jasonleenaylor jasonleenaylor deleted the chore/updatelibpalaso branch November 27, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants