Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chorus.Mercurial package issue on Linux #399

Closed
wants to merge 2 commits into from

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Apr 26, 2024

Version 6.5.1.25 of the SIL.Chorus.Mercurial package had a few missing files that cause test failures in some circumstances; 6.5.1.29 fixes that omission.


This change is Reviewable

@rmunn
Copy link
Contributor Author

rmunn commented Apr 26, 2024

I should note that the missing files are compiled C extensions, which I compiled for Python 3.8 and above since those are the currently-supported versions of Python (3.7 went out of support in October 2023, earlier versions were of course earlier than that). But our TeamCity build agent for linux64, which has been failing to build ever since the SIL.Chorus.Mercurial package was updated to 6.5.1 (which requires Python 3), is running Ubuntu Xenial, where the Python version was 3.5.

If we want to get this building on TeamCity, we might need to update the build runner over there to Ubuntu 22.04. (Or even 24.04, which just came out today). Either that, or move the NuGet packaging-and-release build to GitHub Actions.

(I don't care where it builds, I just want it to be able to consume a NuGet package with the changes from #398).

@rmunn
Copy link
Contributor Author

rmunn commented Apr 29, 2024

PR 397 changes the package version to 6.* so that it will automatically pull in any future Mercurial packaging fixes. I'll change this PR to do the same so that PR 397 won't have any merge conflicts to deal with once it's ready to merge.

Version 6.5.1.25 of the SIL.Chorus.Mercurial package had a few missing
files that cause test failures in some circumstances; 6.5.1.29 fixes
that omission. We actually set the version to `6.*` so that any future
bugfixes will also be pulled in automatically.
@rmunn rmunn force-pushed the bug/fix-mercurial-linux-issue branch from e93ef42 to 4f09d13 Compare April 29, 2024 03:06
@rmunn
Copy link
Contributor Author

rmunn commented May 14, 2024

@jasonleenaylor - Any objections to my merging this before PR #397 is fully ironed out? I've been holding off so as to not cause merge conflicts, but perhaps that's a little silly for a one-line change.

@rmunn rmunn self-assigned this May 14, 2024
@jasonleenaylor
Copy link
Contributor

Robin, sorry I didn't see your comment here earlier. After merging this with the results of the ci-cd build there are no changes left in this commit, so I'm going to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants