Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to macOS-14 #147

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Update to macOS-14 #147

merged 2 commits into from
Jan 13, 2025

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jan 13, 2025

I think Thot will also have to be updated. - see #148


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit January 13, 2025 14:05
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


.github/workflows/ci.yml line 16 at r1 (raw file):

    strategy:
      matrix:
        os: [ubuntu-latest, macos-14, windows-latest]

Try switching to macos-13. macos-14 is on ARM and macos-13 is on x64.

@johnml1135
Copy link
Collaborator Author

.github/workflows/ci.yml line 16 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Try switching to macos-13. macos-14 is on ARM and macos-13 is on x64.

If it works, it works.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (44bfe87) to head (e041c6a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   88.31%   88.33%   +0.02%     
==========================================
  Files         275      275              
  Lines       16192    16192              
==========================================
+ Hits        14300    14304       +4     
+ Misses       1892     1888       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 9110963 into main Jan 13, 2025
14 checks passed
@johnml1135 johnml1135 deleted the update_macos branch January 13, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants