Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default ignores #105

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

pbredenberg
Copy link
Contributor

@pbredenberg pbredenberg commented Nov 22, 2024

In the transition to flat config, I didn't notice this detail from the 8.57 docs:

If ignores is used without any other keys in the configuration object, then the patterns act as global ignores.

Ignores were previously added inside a configuration object that was shared with other properties, so ESLint did not apply them globally.

This PR breaks ignores out into their own file. By keeping ignores in their own file, we will hopefully avoid a similar mistake in the future.

This also removes a DS_Store file and ignores like files.

Comment on lines 3 to 5
'cdk.out/*',
'.esbuild/*',
'dist/*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to match nested files?

Suggested change
'cdk.out/*',
'.esbuild/*',
'dist/*',
'**/cdk.out/**',
'**/.esbuild/**',
'**/dist/**',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gaslighting myself. This is what I thought I checked in.

@onebytegone onebytegone merged commit 18ed84b into silvermine:master Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants