FIX Add SS-2023-001 style security commits. #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/master/include-ss-commits
branch
from
0133d99
to
acf2b11
Compare
Noticed this in passing while reviewing another change
GuySartorelli
force-pushed
the
pulls/master/include-ss-commits
branch
from
acf2b11
to
59fc682
Compare
emteknetnz
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this in passing while reviewing another change. We sometimes use this old format for security vulnerabilities that we can't issue CVEs for, such as SS-2023-001
Not sure why this was ever changed to mark them as "other" changes, but we definitely do treat these the same as we do with security issues we can assign CVEs to.
Issue