FIX Multi HTML entities in image shortcodes

silverstripe · Aug 7, 2023 · 57c6adf · 57c6adf
1 parent 1730623
commit 57c6adf
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/Shortcodes/ImageShortcodeProvider.php b/src/Shortcodes/ImageShortcodeProvider.php
@@ -156,7 +156,7 @@ public static function regenerate_shortcode($args, $content, $parser, $shortcode
         // Rebuild shortcode
         $parts = [];
         foreach ($args as $name => $value) {
-            $htmlValue = Convert::raw2att($value);
+            $htmlValue = htmlspecialchars($value ?? '', ENT_QUOTES, 'UTF-8', false);
             $parts[] = sprintf('%s="%s"', $name, $htmlValue);
         }
         return sprintf("[%s %s]", $shortcode, implode(' ', $parts));