Merge pull request #778 from creative-commoners/pulls/5/remove-widgets

API Remove widgets
silverstripe · Aug 22, 2024 · 63af1fb · 63af1fb
2 parents 9768b27 + 5e44aa7
commit 63af1fb
Show file tree

Hide file tree

Showing 35 changed files with 31 additions and 1,314 deletions.
diff --git a/README.md b/README.md
@@ -10,7 +10,6 @@
 
 ### Suggested Modules
 
-* Silverstripe Widgets Module
 * Silverstripe Comments Module
 
 ## Installation

diff --git a/_config/config.yml b/_config/config.yml
@@ -4,12 +4,3 @@ Name: blogconfig
 SilverStripe\Security\Member:
   extensions:
     - SilverStripe\Blog\Model\BlogMemberExtension
-
----
-Name: featuredpostswidget
-Only:
-  moduleexists: silverstripe/widgets
----
-SilverStripe\Blog\Model\BlogPost:
-  extensions:
-    - SilverStripe\Blog\Model\BlogPostFeaturedExtension
diff --git a/client/dist/styles/main.css b/client/dist/styles/main.css
diff --git a/client/src/styles/blog.scss b/client/src/styles/blog.scss
@@ -26,14 +26,6 @@ ul.blogTagCloud {
     }
   }
 
-  .blog-sidebar .WidgetHolder ul {
-    margin-left: 0;
-
-    li {
-      list-style-type: none;
-    }
-  }
-
   .tagCount10 {
     font-size: $base-tag-font-size + 22pt;
   }

diff --git a/docs/en/configuring-widgets.md b/docs/en/configuring-widgets.md
diff --git a/docs/en/index.md b/docs/en/index.md
@@ -3,7 +3,6 @@
 ## Development
  * [Configuring blog posts in Sitetree](configuring-blog-posts.md)
  * [Configuring blog when on large websites](configuring-large-websites.md)
- * [Configuring widgets](configuring-widgets.md)
  * [Configuring pagination](configuring-pagination.md)
  * [Configuring featured image uploads](configuring-featured-images.md)
 

diff --git a/docs/en/userguide/index.md b/docs/en/userguide/index.md
@@ -6,7 +6,7 @@ summary: Working with blogging and comments in SilverStripe CMS.
 
 ## Before we begin
 
-Make sure that your SilverStripe CMS installation has the [Blog](https://addons.silverstripe.org/add-ons/silverstripe/blog/) module and optional, [Widgets](https://addons.silverstripe.org/add-ons/silverstripe/widgets/) and [Comments](https://addons.silverstripe.org/add-ons/silverstripe/comments/) modules installed.
+Make sure that your SilverStripe CMS installation has the [Blog](https://addons.silverstripe.org/add-ons/silverstripe/blog/) module and optional, and [Comments](https://addons.silverstripe.org/add-ons/silverstripe/comments/) modules installed.
 
 ## Blogging features
 
@@ -16,5 +16,4 @@ Make sure that your SilverStripe CMS installation has the [Blog](https://addons.
  * [Roles](roles.md)
  * [RSS Feed](rss-feed.md)
  * [Tags and categories](tags-and-categories.md)
- * [Using widgets](using-widgets.md)
  * [Managing comments](managing-comments.md)
diff --git a/docs/en/userguide/using-widgets.md b/docs/en/userguide/using-widgets.md
diff --git a/src/Model/BlogCategory.php b/src/Model/BlogCategory.php
@@ -86,6 +86,7 @@ private function scaffoldFormFieldForManyRelation(
         $parent = ($ownerRecord instanceof SiteTree) ? $ownerRecord->Parent() : null;
         $field = TagField::create(
             $relationName,
+            /** @phpstan-ignore translation.key (we need the key to be dynamic here) */
             _t($ownerRecord->ClassName . '.' . $relationName, $fieldTitle),
             ($parent instanceof Blog) ? $parent->Categories() : static::get(),
             $ownerRecord->$relationName()

diff --git a/src/Model/BlogPost.php b/src/Model/BlogPost.php
@@ -106,13 +106,11 @@ class BlogPost extends Page
 
     /**
      * The ProvideComments db column is defined in the silverstripe/comments module
-     * The InheritSideBar db column is defined in the silverstripe/widgets module
      *
      * @var array
      */
     private static $defaults = [
         'ShowInMenus'     => false,
-        'InheritSideBar'  => true,
         'ProvideComments' => true
     ];
 

diff --git a/src/Model/BlogPostFeaturedExtension.php b/src/Model/BlogPostFeaturedExtension.php
diff --git a/src/Model/BlogTag.php b/src/Model/BlogTag.php
@@ -86,6 +86,7 @@ private function scaffoldFormFieldForManyRelation(
         $parent = ($ownerRecord instanceof SiteTree) ? $ownerRecord->Parent() : null;
         $field = TagField::create(
             $relationName,
+            /** @phpstan-ignore translation.key (we need the key to be dynamic here) */
             _t($ownerRecord->ClassName . '.' . $relationName, $fieldTitle),
             ($parent instanceof Blog) ? $parent->Tags() : static::get(),
             $ownerRecord->$relationName()

diff --git a/src/Widgets/BlogArchiveWidget.php b/src/Widgets/BlogArchiveWidget.php