ENH Add generic types #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/4/add-generics
branch
2 times, most recently
from
107a26b
to
204a993
Compare
emteknetnz
requested changes
Jan 17, 2024
src/Model/BlogController.php
Outdated
| @@ -443,7 +443,7 @@ public function getFilterDescription() | |||
| /** | |||
| * Returns a list of paginated blog posts based on the BlogPost dataList. | |||
| * | |||
| * @return PaginatedList | |||
| * @return PaginatedList<ArrayList, BlogPost> | |||
There was a problem hiding this comment.
Could you just double check this is correct - $allPosts = $this->blogPosts ?: ArrayList::create(); - $this->blogPosts has a docblock var of DataList and when it's assigned by methods like getCurrentProfilePosts() it's a DataList
There was a problem hiding this comment.
Ahh, I must have missed that, good call. I'll just use SS_List instead - this method will probably mostly be called in a template anyway so doesn't matter too much.
GuySartorelli
force-pushed
the
pulls/4/add-generics
branch
from
204a993
to
8ec5b93
Compare
emteknetnz
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 and the associated PRs in silverstripe/cms and silverstripe/lumberjack for these generics to take effect.
Issue