Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove tests for unsupported optional modules #763

Merged

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/.github#272

These are tests for optional modules that were supported in CMS 4, though are not supported in CMS 5

The behat test will cause the blog module erronously fail if from recipe-kitchen-sink as the widgets + comments modules are only in require-dev, and thus won't be installed under kitchen sink, though they are when installing from blog

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. If anyone in the community is still using those modules and we accidentally break things from this module, they can raise PRs to fix it.

@GuySartorelli GuySartorelli merged commit 34255c7 into silverstripe:4.2 Jun 10, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.2/remove-tests branch June 10, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants