Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Replace Extension subclasses #2992

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 20, 2024

@emteknetnz emteknetnz force-pushed the pulls/6/replace-extension-subclasses branch 2 times, most recently from 90f5e11 to d7a9d8f Compare August 25, 2024 22:22
@emteknetnz emteknetnz marked this pull request as ready for review August 25, 2024 22:52
@emteknetnz emteknetnz force-pushed the pulls/6/replace-extension-subclasses branch from d7a9d8f to c013acc Compare August 28, 2024 02:17
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending question in silverstripe/silverstripe-behat-extension#281 about "flush only"

@emteknetnz emteknetnz force-pushed the pulls/6/replace-extension-subclasses branch from c013acc to a7b08b0 Compare August 29, 2024 00:36
@emteknetnz emteknetnz force-pushed the pulls/6/replace-extension-subclasses branch from a7b08b0 to 344a7c5 Compare August 29, 2024 01:54
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit e0526b5 into silverstripe:6 Aug 29, 2024
12 of 14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/replace-extension-subclasses branch August 29, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants