ENH Add generic types #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jan 17, 2024
| @@ -17,6 +18,8 @@ | |||
| /** | |||
| * CMSPageEditController extension to receive the additional action button from | |||
| * SiteTreeContentReview::updateCMSActions() | |||
| * | |||
| * @extends LeftAndMainExtension<CMSMain> | |||
There was a problem hiding this comment.
Suggested change
| * @extends LeftAndMainExtension<CMSMain> | |
| * @extends LeftAndMainExtension<CMSPageEditController|ContentReviewCMSExtension> |
There was a problem hiding this comment.
As discussed in person, both CMSPageEditController and CMSPageSettingsController which this is applied to are subclasses of CMSMain, so it makes sense to use that superclass as the typehint here.
emteknetnz
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 and the corresponding PR from silverstripe/admin for these generics to take effect.
Issue