FIX Set empty date to null #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
emteknetnz
force-pushed
the
pulls/6/field-validators
branch
from
89c3647
to
3ed6eb0
Compare
GuySartorelli
requested changes
Oct 22, 2024
| @@ -509,6 +509,9 @@ public function advanceReviewDate() | |||
| DBDatetime::now()->getTimestamp() | |||
| ); | |||
|
|
|||
| $x=DBDate::create()->setValue($nextDateTimestamp)->Format(DBDate::ISO_DATE); | |||
| ; | |||
| @@ -509,6 +509,9 @@ public function advanceReviewDate() | |||
| DBDatetime::now()->getTimestamp() | |||
| ); | |||
|
|
|||
| $x=DBDate::create()->setValue($nextDateTimestamp)->Format(DBDate::ISO_DATE); | |||
There was a problem hiding this comment.
What is this $x variable??
Comment on lines
+668
to
+665
| } elseif ($nextDate === false) { | ||
| $this->owner->NextReviewDate = null; |
There was a problem hiding this comment.
How would it be false? You updated the return values of getReviewDate() to not return false.
There was a problem hiding this comment.
I can't remember. Looking at that method it still has return $page->obj('NextReviewDate'); so presumbably that was returning false in some circumstances
emteknetnz
force-pushed
the
pulls/6/field-validators
branch
from
3ed6eb0
to
8622bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11403
Setting a DBDate to false will now throw an validation exception, so set to null instead