New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Don't use keyword "self" #155

Merged

emteknetnz merged 1 commit into silverstripe:3.2 from creative-commoners:pulls/3.2/no-keyword-self

Jul 29, 2024

Member

GuySartorelli commented Jul 28, 2024

Fixes https://github.com/silverstripe/silverstripe-elemental-bannerblock/actions/runs/10135632357/job/28023263071

Error: Can't use keyword 'self'. Use 'BannerBlock' instead.
 ------ ------------------------------------------------------
  Line   Block/BannerBlock.php                                 
 ------ ------------------------------------------------------
  113    Can't use keyword 'self'. Use 'BannerBlock' instead.  
 ------ ------------------------------------------------------

Issues

Broken builds and merge-ups .github#287


          ENH Don't use keyword "self"

71c79b8

GuySartorelli mentioned this pull request

Broken builds and merge-ups silverstripe/.github#287

Closed

emteknetnz approved these changes

View reviewed changes

emteknetnz merged commit fbbad23 into silverstripe:3.2

13 checks passed

emteknetnz deleted the pulls/3.2/no-keyword-self branch

July 29, 2024 04:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet