API Standardise extension hooks

silverstripe · Aug 19, 2024 · f202e67 · f202e67
1 parent 860df12
commit f202e67
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Extensions/ElementalAreasExtension.php b/src/Extensions/ElementalAreasExtension.php
@@ -298,7 +298,7 @@ public function ensureElementalAreasExist($elementalAreaRelations)
      *
      * @return void
      */
-    public function requireDefaultRecords()
+    protected function onRequireDefaultRecords()
     {
         if (!$this->supportsElemental()) {
             return;

diff --git a/src/Extensions/ElementalLeftAndMainExtension.php b/src/Extensions/ElementalLeftAndMainExtension.php
@@ -11,7 +11,7 @@
  */
 class ElementalLeftAndMainExtension extends Extension
 {
-    public function init()
+    protected function onInit()
     {
         Requirements::add_i18n_javascript('dnadesign/silverstripe-elemental:client/lang');
     }

diff --git a/src/Extensions/ElementalPageExtension.php b/src/Extensions/ElementalPageExtension.php
@@ -119,7 +119,7 @@ protected function updateAnchorsOnPage(array &$anchors): void
         });
     }
 
-    public function MetaTags(&$tags)
+    protected function updateMetaTags(&$tags)
     {
         if (!Controller::has_curr()) {
             return;

diff --git a/tests/Src/ValidationFailedExtension.php b/tests/Src/ValidationFailedExtension.php
@@ -11,7 +11,7 @@ class ValidationFailedExtension extends Extension implements TestOnly
 {
     public const INVALID_TITLE_MESSAGE = '%s is invalid';
 
-    public function validate(ValidationResult $result)
+    protected function updateValidate(ValidationResult $result)
     {
         $result->addFieldError('Title', sprintf(static::INVALID_TITLE_MESSAGE, ClassInfo::shortName($this->owner)));
     }