Repeated database queries from BaseElement::getAreaRelationName()

[kinglozzer]

During element rendering, forTemplate() calls getRenderTemplates(), which in turn calls getAreaRelationName() to help build a list of applicable templates (presumably so that elements can be rendered differently based on which area they belong to).

BaseElement::getAreaRelationName() calls $this->Parent(), which runs through a typical flow for fetching a has_one component. However, these calls aren’t cached so this results in an additional database query for each element as it’s rendered:

silverstripe-elemental/src/Models/BaseElement.php

Lines 758 to 760 in f626840

	if ($page) {
	$has_one = $page->config()->get('has_one');
	$area = $this->Parent();

I’d suggest we replace this with something like:

$class = DataObject::getSchema()->hasOneComponent($this, 'Parent');
$area = ($this->ParentID) ? DataObject::get_by_id($class, $this->ParentID) : null;
$area = $area ?: ElementalArea::singleton();

PR

• FIX: Save repeated database queries to fetch elemental area name (fixes #928) #1085

[michalkleiner]

Just a quick thought — wasn't there an enhancement from @mfendeksilverstripe around gettoppage or similar? Not sure if it applies here but it's the first thing that came to mind.

[mfendeksilverstripe]

You're right @michalkleiner , we do have a feature addressing this. It's opt in in 4 and built in on master. See Top page feature for more details @kinglozzer.

[kinglozzer]

Unless I’m misunderstanding something, I’m not sure that’d help in this case. The code in question has already fetched the page, it’s another query after that that then fetches an ElementalArea record that I’m trying to eliminate 😄

[mfendeksilverstripe]

You're right @kinglozzer, the Top page feature is focused on page lookup from blocks. I think it's reasonable to add a cached call for elemental area as well.

[GuySartorelli]

Pull request merged. It'll be automatically tagged by GitHub Actions.