Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Save repeated database queries to fetch elemental area name (fixes #928) #1085

Merged
merged 1 commit into from
Aug 23, 2023
Merged

FIX: Save repeated database queries to fetch elemental area name (fixes #928) #1085

merged 1 commit into from
Aug 23, 2023

Conversation

kinglozzer
Copy link
Member

Issue: #928

GuySartorelli
GuySartorelli requested changes Aug 22, 2023
View reviewed changes
src/Models/BaseElement.php Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli mentioned this pull request Aug 22, 2023
Closed
GuySartorelli
GuySartorelli approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well locally.

@GuySartorelli GuySartorelli merged commit d8a76f3 into silverstripe:4.11 Aug 23, 2023
12 checks passed
@kinglozzer kinglozzer deleted the 928-repeated-queries branch August 24, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinglozzer @GuySartorelli