ENH Add generic types

silverstripe · Jan 11, 2024 · 0cbd9ab · 0cbd9ab
1 parent 67e0e1c
commit 0cbd9ab
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/ErrorPageController.php b/src/ErrorPageController.php
@@ -8,6 +8,8 @@
 
 /**
  * Controller for ErrorPages.
+ *
+ * @extends PageController<ErrorPage>
  */
 class ErrorPageController extends PageController
 {
@@ -30,7 +32,6 @@ protected function init()
      */
     public function handleRequest(HTTPRequest $request): HTTPResponse
     {
-        /** @var ErrorPage $page */
         $page = $this->data();
         $response = parent::handleRequest($request);
         $response->setStatusCode($page->ErrorCode);

diff --git a/src/ErrorPageControllerExtension.php b/src/ErrorPageControllerExtension.php
@@ -9,13 +9,15 @@
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\HTTPResponse_Exception;
 use SilverStripe\Core\Extension;
+use SilverStripe\Forms\Form;
 
 /**
  * Enhances error handling for a controller with ErrorPage generated output
+ *
+ * @extends Extension<Controller|Form>
  */
 class ErrorPageControllerExtension extends Extension
 {
-
     /**
      * Used by {@see RequestHandler::httpError}
      *

diff --git a/src/ErrorPageFileExtension.php b/src/ErrorPageFileExtension.php
@@ -2,15 +2,17 @@
 
 namespace SilverStripe\ErrorPage;
 
+use SilverStripe\Assets\Shortcodes\FileShortcodeProvider;
 use SilverStripe\ORM\DataExtension;
 use SilverStripe\ORM\DataObject;
 
 /**
  * Decorates {@see File} with ErrorPage support
+ *
+ * @extends DataExtension<FileShortcodeProvider>
  */
 class ErrorPageFileExtension extends DataExtension
 {
-
     /**
      * Used by {@see File::handle_shortcode}
      *