Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Change type to Int #206

Open
wants to merge 1 commit into
base: 2
Choose a base branch
from
Open

FIX Change type to Int #206

wants to merge 1 commit into from

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/silverstripe-framework#11408

Elsewhere in the file it is set and tested as an int, causes a ValidationException to be thrown on dev build

@emteknetnz emteknetnz mentioned this pull request Oct 10, 2024
Open
10 tasks
@emteknetnz emteknetnz marked this pull request as draft October 10, 2024 21:19
@emteknetnz emteknetnz marked this pull request as ready for review October 21, 2024 21:33
GuySartorelli
GuySartorelli approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all PRs are ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli