Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Update code to reflect changes in template layer #570

Open
wants to merge 1 commit into
base: 6
Choose a base branch
from
Open

ENH Update code to reflect changes in template layer #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Authenticator/LoginHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public function doLogin($data, MemberLoginForm $form, HTTPRequest $request)

/**
* Action handler for loading the MFA authentication React app
* Template variables defined here will be used by the rendering controller's template - normally Page.ss
* Template variables defined here will be used by the rendering controller's template - normally Page
*
* @return HTTPResponse|array
*/
Expand Down
2 changes: 1 addition & 1 deletion src/Service/MethodRegistry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function getMethods(): array
if (!$method instanceof MethodInterface) {
throw new UnexpectedValueException(sprintf(
'Given method "%s" does not implement %s',
$method,
get_class($method),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary anymore, since I had to revert the changes to what ModelData::__toString() returns - but it was still a really bad idea to assume that will return the class name. I still think this change is objectively good and worthwhile.

MethodInterface::class
));
}
Expand Down
Loading