fix: incorrect created date shown on backup method #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice finds! The changes look ok to me. I wonder whether we should require the member to be passed always and not fallback to the current user at all. You may also want to update the doc block when you add a method param and strongly type it to Member. |
|
The lint failure is related. |
2 tasks
GuySartorelli
requested changes
Oct 23, 2024
| * @return RegisteredMethod|null | ||
| */ | ||
| protected function getBackupMethod(): ?RegisteredMethod | ||
| protected function getBackupMethod(Member $member): ?RegisteredMethod |
There was a problem hiding this comment.
We can't add properties to protected methods in a minor release, as that's a violation of our public API. This change would need to happen in a major release.
Is there a way you can fix this bug without modifying the existing API method signatures?
There was a problem hiding this comment.
@GuySartorelli I'm now storing Member in a private property and reverted the method signature back to the original. Let me know if that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #571
When viewing a member, at the bottom of their member screen on the backend it says whether they have MFA setup and when their recovery codes were created. However, for any user that has MFA setup, the recovery codes created date always shows as today.