Skip to content

Commit

Permalink
DEP Use PHPUnit 11
Browse files Browse the repository at this point in the history
  • Loading branch information
emteknetnz committed Sep 9, 2024
1 parent 1eea4a2 commit ca51224
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"silverstripe/vendor-plugin": "^2"
},
"require-dev": {
"phpunit/phpunit": "^9.6",
"phpunit/phpunit": "^11.3",
"squizlabs/php_codesniffer": "^3.7",
"silverstripe/standards": "^1",
"phpstan/extension-installer": "^1.3"
Expand Down
7 changes: 3 additions & 4 deletions tests/ReportAdminTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use SilverStripe\Reports\Tests\ReportAdminTest\CannotViewReport;
use SilverStripe\Reports\Tests\ReportAdminTest\FakeReport;
use SilverStripe\Reports\Tests\ReportAdminTest\FakeReport2;
use PHPUnit\Framework\Attributes\DataProvider;

class ReportAdminTest extends FunctionalTest
{
Expand Down Expand Up @@ -46,7 +47,7 @@ public function testBreadcrumbsAreGenerated()
$this->assertSame('Fake report two', $map['Title']);
}

public function provideShowReport(): array
public static function provideShowReport(): array
{
return [
'cannot view' => [
Expand All @@ -60,9 +61,7 @@ public function provideShowReport(): array
];
}

/**
* @dataProvider provideShowReport
*/
#[DataProvider('provideShowReport')]
public function testShowReport(string $reportClass, int $expected): void
{
$this->logInWithPermission('ADMIN');
Expand Down

0 comments on commit ca51224

Please sign in to comment.