Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Remove translation values that match english source values #19

Merged
merged 1 commit into from
Sep 1, 2023
Merged

FIX Remove translation values that match english source values #19

merged 1 commit into from
Sep 1, 2023

Conversation

emteknetnz
Copy link
Member

Issue #18

@emteknetnz emteknetnz mentioned this pull request Aug 31, 2023
Closed
GuySartorelli
GuySartorelli requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these implementations into new methods, and call them after the merge step from run(). That makes it clearer what's happening in what order.

src/Translator.php Outdated Show resolved Hide resolved
src/Translator.php Outdated Show resolved Hide resolved
src/Translator.php Show resolved Hide resolved
src/Translator.php Outdated Show resolved Hide resolved
src/Translator.php Show resolved Hide resolved
GuySartorelli
GuySartorelli requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some minor tweaks.

src/Translator.php Show resolved Hide resolved
src/Translator.php Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@GuySartorelli GuySartorelli merged commit 4a87d64 into silverstripe:1.1 Sep 1, 2023
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/1.1/js-translations branch September 1, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli